Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for improving the guide #29

Open
falexwolf opened this issue May 1, 2024 · 5 comments
Open

Suggestions for improving the guide #29

falexwolf opened this issue May 1, 2024 · 5 comments

Comments

@falexwolf
Copy link
Member

falexwolf commented May 1, 2024

Shall we remove this? It's now running in a script.

image
@falexwolf
Copy link
Member Author

I'm questioning the value of the "pre-populated LaminDB instance".

  • Pro: It makes the lineage graph more interesting.
  • Con: It requires to look into a notebook and it all appears quite complicated. It's also weird that the input path for the actual nextflow command is NOT derived from a folder-like artifact, but hardcoded as a string.
image

(Also: Let's remove the "Setup" header so that it looks less complicated. This is what we aligned on a while back I think.)

@falexwolf

This comment was marked as resolved.

@falexwolf
Copy link
Member Author

Adding an assert statement at the end of the notebook that programmatically checks that the lineage is correct:

image

@falexwolf

This comment was marked as resolved.

@falexwolf
Copy link
Member Author

Yes, I think we agreed on removing the "Setup" header: https://laminlabs.slack.com/archives/C046F63LJJ2/p1705483044994189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant