We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
from_anndata
from_path
Functions like from_path and from_anndata should only be added if the class is an Artifact Registry.
We probably need a
create_registry <- function(instance, module, api, registry_name, registry_schema) { public <- list( initialize = function(instance, module, api, registry_name, registry_schema) { super$new( instance = instance, module = module, api = api, registry_name = registry_name, registry_schema = registry_schema ) }, # ... ) if (registry_name == "Artifact") { public$from_path <- ... public$from_anndata <- .. public$from_dir <- ... public$from_mudata <- ... } if (registry_names == "FeatureSet") { public$from_values <- ... } # ... RichRegistryClass <- R6::R6Class( paste0(registry_name, "Registry"), cloneable = FALSE, inherit = Registry, public = public ) RichRegistryClass }
Or the other way around
create_registry <- function(instance, module, api, registry_name, registry_schema) { public <- list( initialize = function(instance, module, api, registry_name, registry_schema) { super$new( instance = instance, module = module, api = api, registry_name = registry_name, registry_schema = registry_schema ) }, from_path = function(...) { ... }, from_anndata = function(...) { ... }, from_dir = function(...) { ... }, # ... ) if (registry_name != "Artifact") { public$from_path <- NULL public$from_anndata <- NULL public$from_dir <- NULL public$from_mudata <- NULL } if (registry_names != "FeatureSet") { public$from_values <- NULL } # ... RichRegistryClass <- R6::R6Class( paste0(registry_name, "Registry"), cloneable = FALSE, inherit = Registry, public = public ) RichRegistryClass }
Originally posted by @rcannood in #85 (comment)
The text was updated successfully, but these errors were encountered:
Somewhat related to #63
Sorry, something went wrong.
No branches or pull requests
Functions like
from_path
andfrom_anndata
should only be added if the class is an Artifact Registry.We probably need a
Or the other way around
Originally posted by @rcannood in #85 (comment)
The text was updated successfully, but these errors were encountered: