Remove flashmessenger view helper #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
Feb 1, 2022
|
7.4 on lowest looks stuck - can you re-trigger please @Ocramius |
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
- Removes magic method docs for removed helpers - Removes stray factory definition for removed helper Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Remove escaper from dev deps - it crept back in during a merge and is already present in deps Remove flash messenger from dev deps. It is no longer referenced anywhere. Signed-off-by: George Steel <[email protected]>
gsteel
force-pushed
the
remove-flashmessenger-view-helper
branch
from
10fa20b to
db23fc8
Compare
|
GHA didn't start at all here 🤔 |
|
Welp, it's broken again: https://www.githubstatus.com/ |
|
Not again 🙄 |
|
I think pushing an empty commit would give us feedback here - really sorry to push it on contributors, but can't do it from here ATM :| |
I think GHA is still down isn't it? |
|
Seems to be working/picking up stuff - the hook system was completely broken though |
gsteel
force-pushed
the
remove-flashmessenger-view-helper
branch
2 times, most recently
from
80c574d to
93c789d
Compare
Closes laminas#133 Tests removed in this branch contain the last remaining usage of Prophecy Signed-off-by: George Steel <[email protected]>
gsteel
force-pushed
the
remove-flashmessenger-view-helper
branch
from
93c789d to
06ad4e9
Compare
|
Appears to have gone green despite the UI not showing the checks: https://github.com/laminas/laminas-view/actions/runs/2029729860 |
Ocramius
requested changes
Mar 23, 2022
|
Thanks @gsteel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rebases and resolves #47
Also closes #8
Closes #16
As this is the last remnant of prophecy usage, this pull also removes
phpspec/prophecyfrom dev depsCloses #133