Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silent fail on Json::encode Error #33

Closed
michalbundyra opened this issue Jan 15, 2020 · 1 comment · Fixed by #125
Closed

silent fail on Json::encode Error #33

michalbundyra opened this issue Jan 15, 2020 · 1 comment · Fixed by #125
Labels
BC Break Enhancement
Milestone
3.0.0

Comments

@michalbundyra
Copy link
Member

https://github.com/zendframework/zend-view/blob/ef3d64b8815a069c60cf7b9a6de636ee26fc9fe0/src/Renderer/JsonRenderer.php#L151

if json_last_error() != 0 no exception ist thrown

Originally posted by @lkainers at zendframework/zend-view#9
@michalbundyra
Copy link
Member Author

Source of the problem is in Zend\Json\Json::encode not in Zend\View\Renderer\JsonRenderer.

Originally posted by @Martin-P at zendframework/zend-view#9 (comment)

@michalbundyra michalbundyra mentioned this issue Jan 15, 2020
Open
@gsteel gsteel mentioned this issue Feb 25, 2021
Closed
@gsteel gsteel mentioned this issue Jan 31, 2022
Merged
@Ocramius Ocramius added this to the 3.0.0 milestone Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC Break Enhancement
Projects
None yet
Milestone
3.0.0
2 participants
@Ocramius @michalbundyra