We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It seems like the Documentation for Laminas\Validator\GpsPoint is missing. I never knew that there is a validator for this. 🤯
Laminas\Validator\GpsPoint
The text was updated successfully, but these errors were encountered:
I believe this validator should either be rewritten or removed entirely as it will return true for the input "foo, bar"
It expects a string as input in the form "latitude, longitude" :
public function isValid($value) { if (strpos($value, ',') === false) { $this->error(self::INCOMPLETE_COORDINATE, $value); return false; } [$lat, $long] = explode(',', $value);
but the isValidCoordinate() method blindly casts the supposed lat or long to a double:
isValidCoordinate()
$doubleLatitude = (double) $value; if ($doubleLatitude <= $maxBoundary && $doubleLatitude >= $maxBoundary * -1) { return true; }
which results in a 0 value in the case of non-numerical strings, which then passes validation as a valid lat/long.
At the very least it should have explicit comments stating that the expected input is in a very particular format already.
Sorry, something went wrong.
No branches or pull requests
Feature Request
Summary
It seems like the Documentation for
Laminas\Validator\GpsPoint
is missing. I never knew that there is a validator for this. 🤯The text was updated successfully, but these errors were encountered: