Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the GPSPoint validator less english language centric #170

Open
codisart opened this issue Jan 12, 2023 · 0 comments
Open

Making the GPSPoint validator less english language centric #170

codisart opened this issue Jan 12, 2023 · 0 comments

Comments

@codisart
Copy link
Contributor

codisart commented Jan 12, 2023

Feature Request

Q A
New Feature yes
RFC maybe
BC Break yes

Summary

During my investigation of the issue #135, I realized that the validation is maybe too much english language centric.
I am french and in our language and in many others, the comma is used for decimal numbers instead of the dot so "20.45" becomes "20,45".

So we don't use the comma as separator when using the DD format for a set of coordinates. As we can see in this wikipedia article, a dash and witespaces are used in replacement.
I found it also in spanish

I suggest to allow the format to use other separators than the comma, like the dash "-" or the semi-colon ";".

Here a non complete list of suggested formats to allow:

  • 38° 53' 23" N;77° 00' 32" W
  • 38,8897°; -77,0089°
  • 38° 53' 23" N - 77° 00' 32" W
  • 38,8897° - -77,0089°
@codisart codisart changed the title Making the GPSPoint validator less english language centered Making the GPSPoint validator less english language centric Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant