Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP 8.4 Support to the 3.x series #243

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Add PHP 8.4 Support to the 3.x series #243

merged 1 commit into from
Oct 28, 2024

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Oct 18, 2024 •
edited
Loading

Description

Adds 8.4 support to the 3.x series

  • Ignores platfrom reqs on 8.4
  • Fixes a bunch of docs linting problems
  • Bumps stdlib to an 8.4 compatible release
  • Bumps all dev deps
  • Baselines/fixes a number of new Psalm issues - most of this is around the types being moved from ConfigInterface to ServiceManager, and changes to Psalm's reporting of certain issues.

@gsteel gsteel added this to the 3.23.0 milestone Oct 18, 2024
@gsteel gsteel requested a review from boesing October 18, 2024 15:13
@gsteel gsteel mentioned this pull request Oct 22, 2024
Merged
alexmerlin
alexmerlin approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

froschdesign
froschdesign approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@gsteel gsteel self-assigned this Oct 28, 2024
@gsteel gsteel merged commit a864018 into laminas:3.23.x Oct 28, 2024
17 checks passed
@gsteel gsteel deleted the php-8.4 branch October 28, 2024 21:32
@github-actions github-actions bot mentioned this pull request Oct 28, 2024
Merged
@gsteel gsteel mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmerlin alexmerlin alexmerlin approved these changes

@froschdesign froschdesign froschdesign approved these changes

@boesing boesing Awaiting requested review from boesing

Assignees

@gsteel gsteel

Labels
Enhancement
Projects
PHP 8.4
Status: Done
Milestone
3.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gsteel @froschdesign @alexmerlin