Narrow array type for services in ServiceManager configuration
#213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boesing
changed the title
services in ServiceManager configuration
boesing
requested changes
Oct 16, 2023
src/ServiceManager.php
Outdated
| @@ -89,7 +89,7 @@ | |||
| * initializers?: InitializersConfiguration, | |||
| * invokables?: array<string,string>, | |||
| * lazy_services?: LazyServicesConfiguration, | |||
| * services?: array<string,object|array>, | |||
| * services?: array<string,object|array<array-key,mixed>>, | |||
There was a problem hiding this comment.
As requested in #212, please use array<mixed> instead.
There was a problem hiding this comment.
@laminas/technical-steering-committee should we enforce this kind of array notation via our codestandard and if so, are there existing rules for that? That would prevent us from having these kind of "issues" with incompatibilities between psalm/phpstan in the future.
…iceManager fixes laminas#212 Signed-off-by: Thomas Rieschl <[email protected]>
rieschl
force-pushed
the
qa/service-manager-array-shape
branch
from
780fab7 to
10ceb4a
Compare
boesing
approved these changes
Oct 24, 2023
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a more specific array shape for the
serviceskey inServiceManagerConfiguration.fixes #212