Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix controller namespace in event manager #29

Closed
weierophinney opened this issue Dec 31, 2019 · 2 comments
Closed

Fix controller namespace in event manager #29

weierophinney opened this issue Dec 31, 2019 · 2 comments

Comments

@weierophinney
Copy link
Member

This issue has been moved from the zendframework repository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html


Original Issue: https://api.github.com/repos/zendframework/zendframework/issues/7457
User: @0xPaul
Created On: 2015-04-22T09:29:40Z
Updated At: 2015-05-04T14:59:12Z
Body
Controller was only registering the root namespace, e.g. Foo instead of Foo\Bar for a class named Foo\Bar\Baz.


Comment

User: @Martin-P
Created On: 2015-04-28T19:52:56Z
Updated At: 2015-04-28T19:52:56Z
Body
Perhaps you can add:

  • a unittest which shows the correct namespace is returned
  • a separate unittest which shows the wrong namespace is not returned

That way regressions can be avoided.


Comment

User: @0xPaul
Created On: 2015-04-29T08:48:33Z
Updated At: 2015-04-29T08:48:33Z
Body
If by you, you mean someone, then yes. I'm sure someone can do those things.


Comment

User: @Martin-P
Created On: 2015-04-29T09:09:15Z
Updated At: 2015-04-29T09:09:15Z
Body

If by you, you mean someone, then yes. I'm sure someone can do those things.

I'm sure someone can create unittests, but this is not _someone_s PR, it is your PR. So I meant you, @0xPaul 😉



Originally posted by @GeeH at zendframework/zend-mvc#171

@weierophinney
Copy link
Member Author

I have a Ns\SubNs\Controller\IndexController and confirm it is being picked up as Ns\SubNs... There is an undocumented feature, "view_manager" => ["controller_map" => ["Ns" => true]] which was required for the view templates to be in ns/subns/index as opposed to ns/index...


Originally posted by @internalsystemerror at zendframework/zend-mvc#171 (comment)

@alexmerlin
Copy link
Member

Closing issue due to being inactive for more than 1 year.

@alexmerlin alexmerlin closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants