Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[laminas-mvc-view] Drop or update the Url View Helper Factory #155

Open
gsteel opened this issue Jul 19, 2023 · 0 comments
Open

[laminas-mvc-view] Drop or update the Url View Helper Factory #155

gsteel opened this issue Jul 19, 2023 · 0 comments

Comments

@gsteel
Copy link
Member

gsteel commented Jul 19, 2023

The URL view helper factory is a closure created here. This closure will need to be changed to inject the router and route match instances into the helper constructor, or, removed completely to favour the shipped UrlFactory in https://github.com/laminas/laminas-mvc-view when 1.0 is released.

Because the Url helper itself has a different namespace Laminas\Mvc\View\Helper\Url, this is likely a BC break for MVC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant