Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for delegator factories #102

Open
boesing opened this issue Feb 9, 2022 · 0 comments
Open

Unit tests for delegator factories #102

boesing opened this issue Feb 9, 2022 · 0 comments

Comments

@boesing
Copy link
Member

boesing commented Feb 9, 2022

Since we now reverted the bug which was introduced in 3.3.1 and fixed in 3.3.2, unit tests which do actually test if delegator factories are being applied to the services fetched via the laminas-servicemanager would be very helpful.

Ofc, these might break in the next major when we cleanup the current behavior but until then, we should try to avoid having this same issue again in this (and maybe in other repositories).

Reverted in #100

Originally posted by @Ocramius in #99 (comment)


Maybe this could also be a CommonPluginManagerTrait test - so actually finding "dead" delegators.

But in the first place, we should ensure that delegator factories are actually be used within the servicemanager.


References #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant