You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since we now reverted the bug which was introduced in 3.3.1 and fixed in 3.3.2, unit tests which do actually test if delegator factories are being applied to the services fetched via the laminas-servicemanager would be very helpful.
Ofc, these might break in the next major when we cleanup the current behavior but until then, we should try to avoid having this same issue again in this (and maybe in other repositories).
Since we now reverted the bug which was introduced in
3.3.1
and fixed in3.3.2
, unit tests which do actually test if delegator factories are being applied to the services fetched via thelaminas-servicemanager
would be very helpful.Ofc, these might break in the next major when we cleanup the current behavior but until then, we should try to avoid having this same issue again in this (and maybe in other repositories).
Originally posted by @Ocramius in #99 (comment)
Maybe this could also be a CommonPluginManagerTrait test - so actually finding "dead" delegators.
But in the first place, we should ensure that delegator factories are actually be used within the
servicemanager
.References #99
The text was updated successfully, but these errors were encountered: