Wrong phpDoc for AbstractProtocol::_expect

[rarog]

Bug Report

Q	A
Version(s)	2.14.1

Summary

The phpDoc suggests string|array as type of parameter $code, while all calls are int or array of int

Current behavior

All calls of _expect are done with int or array of int. This is then implicitly converted by call of in_array without $strict parameter with previously processed string via preg_split, which means $strict = false and implicit conversion. This is confusing and inconsistent in terms of clean code.

Expected behavior

Either suggest int codes that will be converted to string explicitly or use calls with actual string parameters.

[Ocramius]

Could you point to a code fragment (absolute URI) please?

[froschdesign]

laminas-mail/src/Protocol/AbstractProtocol.php

Lines 310 to 321 in ee318f5

	/**
	* Parse server response for successful codes
	*
	* Read the response from the stream and check for expected return code.
	* Throws a Laminas\Mail\Protocol\Exception\ExceptionInterface if an unexpected code is returned.
	*
	* @param string|array $code One or more codes that indicate a successful response
	* @param int $timeout Per-request timeout value if applicable
	* @throws Exception\RuntimeException
	* @return string Last line of response string
	*/
	protected function _expect($code, $timeout = null)