Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for portuguese from Portugal (pt_PT) #3

Open
weierophinney opened this issue Dec 31, 2019 · 3 comments
Open

Translations for portuguese from Portugal (pt_PT) #3

weierophinney opened this issue Dec 31, 2019 · 3 comments

Comments

@weierophinney
Copy link
Member

Captcha and Validate translations for portuguese from Portugal (pt_PT).


Originally posted by @rolandoisidoro at zendframework/zend-i18n-resources#38

@weierophinney
Copy link
Member Author

We need another Portuguese speaking person to reviewing it. (Two-man rule)


Originally posted by @froschdesign at zendframework/zend-i18n-resources#38 (comment)

@weierophinney
Copy link
Member Author

Hi @froschdesign, I'm also Portuguese and I reviewed @rolandoisidoro translation. It seems good to merge to me!


Originally posted by @falsovsky at zendframework/zend-i18n-resources#38 (comment)

@weierophinney
Copy link
Member Author

Sorry for the late reply.

There seem to be an issue with wrong translation keys used across all languages. This work probably have some of them too since you most likely used english provider as a source.
A work to get all the keys validated is quite time consuming which I lack at the moment.
As such I cannot proceed with merging and releasing this PR.

If someone can undertake the work to validate the keys in english provider and then implement tests to ensure there is no key mismatch between different languages, I will gladly review the work and make sure it is accepted promptly. At which point I will be able to accept this PR as well.


Originally posted by @Xerkus at zendframework/zend-i18n-resources#38 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant