Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing \Laminas\Validator\UndisclosedPassword::$messageTemplates translations #28

Open
Slamdunk opened this issue Oct 20, 2022 · 2 comments
Open

Missing \Laminas\Validator\UndisclosedPassword::$messageTemplates translations #28

Slamdunk opened this issue Oct 20, 2022 · 2 comments
Labels
Bug Something isn't working

Comments

@Slamdunk
Copy link
Contributor

Translations for \Laminas\Validator\UndisclosedPassword::$messageTemplates appear to be missing:

https://github.com/laminas/laminas-validator/blob/41b5201fa1654f086db393875e1352077cc67694/src/UndisclosedPassword.php#L37-L40
@Slamdunk Slamdunk added the Bug Something isn't working label Oct 20, 2022
@froschdesign
Copy link
Member

@Slamdunk
I think some tests (integration) would be good to detect missing or wrong translation keys. Maybe via roave/better-reflection and DirectoriesSourceLocator? 🤔

@Slamdunk
Copy link
Contributor Author

I thought about it but didn't find time to implement it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@froschdesign @Slamdunk