-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An item should not include both author and dc:creator #4
Comments
@glen-84 We then have to check as well:
I will have a deeper look into the code. Thanks for reporting! Originally posted by @froschdesign at zendframework/zend-feed#90 (comment) |
I think we must change the method public static function registerCoreExtensions()
{
$coreExtensions = [
'Atom',
'Content',
'DublinCore',
'GooglePlayPodcast',
'ITunes',
'Slash',
'Threading',
'WellFormedWeb',
];
foreach ($coreExtensions as $coreExtension) {
if (static::hasExtension($coreExtension)) {
static::registerExtension($coreExtension);
}
}
} With this change an extension can be removed (deregister): $extensionManager = new Zend\Feed\Writer\StandaloneExtensionManager();
$extensionManager->remove('DublinCore\Renderer\Entry');
$extensionManager->remove('DublinCore\Renderer\Feed');
Zend\Feed\Writer\Writer::setExtensionManager($extensionManager); @glen-84 Originally posted by @froschdesign at zendframework/zend-feed#90 (comment) |
It does seem to work, but shouldn't this be the default? (i.e. by default it shouldn't include both elements?) Originally posted by @glen-84 at zendframework/zend-feed#90 (comment) |
@glen-84
It was implemented in zend-feed before 2012 and I do not know if there was already a recommendation for this elements to that time. Originally posted by @froschdesign at zendframework/zend-feed#90 (comment) |
I'm facing the same issue, are there any plans to fix this? |
@cmegd |
Using the W3C Feed Validation Service:
Code to reproduce the issue
n/a
Expected results
Only one of
author
anddc:creator
is included.Actual results
Both are included.
Originally posted by @glen-84 at zendframework/zend-feed#90
The text was updated successfully, but these errors were encountered: