Handle PDO driver extensions #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Projects `composer.json` can require specific PDO drivers such as `ext-pdo_mysql`. These are passed to the CI container as `pdo_mysql` and are then passed as `php<version>-pdo_mysql` package to `apt install`. These packages do not exist and thus there will be an error if the appropriate extension(s) was/were not already installed/enabled. This patch handles the most common drivers `mysql`, `pgsql` and `sqlite` and ensure that these are installed/enabled along with the `pdo` extension. Signed-off-by: Maximilian Bösing <[email protected]>
…tenations Signed-off-by: Maximilian Bösing <[email protected]>
|
Why not just install them by default? It is not like they are too large. |
|
Why not install any extension by default then? 🤷🏼♂️ |
gsteel
approved these changes
Oct 3, 2024
|
for the sake of simplicity, I will change my PR to include these as default then. The main idea of the container initially was that it is small but if we agree on having it containing a bunch of defaults, that would work for me. |
|
@boesing Can you continue work on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Projects
composer.jsoncan require specific PDO drivers such asext-pdo_mysql. These are passed to the CI container aspdo_mysqland are then passed asphp<version>-pdo_mysqlpackage toapt install. These packages do not exist and thus there will be an error if the appropriate extension(s) was/were not already installed/enabled. This patch handles the most common driversmysql,pgsqlandsqliteand ensure that these are installed/enabled along with thepdoextension.fixes #252