Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Move Database Connection Credentials to Environment Variables #391

Merged
merged 6 commits into from
Dec 18, 2023

Conversation

anukkrit149
Copy link
Contributor

This pull request includes changes that move the database connection credentials from the codebase to environment variables. This enhances the security of our application by ensuring that sensitive data such as database usernames and passwords are not hardcoded into our source code.

Key Change -
Replacing instances of hardcoded credentials in database connection file with references to environment variables.

Copy link
Collaborator

@SantiagoPittella SantiagoPittella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution. Should be ready to merge after those changes.

.env.example Outdated Show resolved Hide resolved
config/dev.exs Outdated Show resolved Hide resolved
Copy link
Collaborator

@SantiagoPittella SantiagoPittella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution.

@SantiagoPittella SantiagoPittella added this pull request to the merge queue Dec 18, 2023
Merged via the queue into lambdaclass:main with commit a3eb94d Dec 18, 2023
1 check passed
apoorvsadana pushed a commit to karnotxyz/stark_compass_explorer that referenced this pull request Dec 22, 2023
…class#391)

* Added: DB env changes

* Fixes: Added Default Value

* Fixes: Added New line
apoorvsadana pushed a commit to karnotxyz/stark_compass_explorer that referenced this pull request Dec 22, 2023
…class#391)

* Added: DB env changes

* Fixes: Added Default Value

* Fixes: Added New line
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants