Precompute twiddle factors #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #145 +/- ##
=======================================
Coverage 97.38% 97.39%
=======================================
Files 40 40
Lines 6930 6978 +48
=======================================
+ Hits 6749 6796 +47
- Misses 181 182 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MauroToscano
approved these changes
Jul 4, 2023
|
I'm not sure this is a worth tradeoff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #107.
This PR adds twiddle factors precomputation. The twiddle factors affected are the ones that form a vector of length
domain_size.It also fixes linter issues related with the usage of the updated Lambdaworks crates.
It improves the performance of the prover by 4% for fibo 10 and 3% for fibo 100 and regresses the performance of the verifier by 2% for fibo 10 and 3% for fibo 100.