Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need default struct alignment to be 2 bytes instead of 4 #24

Open
mheyer32 opened this issue Sep 3, 2023 · 4 comments
Open

Need default struct alignment to be 2 bytes instead of 4 #24

mheyer32 opened this issue Sep 3, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@mheyer32
Copy link

mheyer32 commented Sep 3, 2023

Quite a few OS structs are misaligned due to the default alignment of 4 byte. They need to be aligned to 2 byte.

@lab313ru lab313ru self-assigned this Sep 3, 2023
@lab313ru lab313ru added the bug Something isn't working label Sep 3, 2023
@lab313ru
Copy link
Owner

lab313ru commented Sep 3, 2023

Thanks. If you can create a PR, it would be great. If not - I'll try to fix that someday...

@mheyer32
Copy link
Author

mheyer32 commented Sep 4, 2023

I did not look into the code and I am not familiar with it. So I cannot really help with a PR. But I do use this extension to reverse engineer Amiga software :-)
Excellent that it exists and is really helpful!

@nicodex
Copy link
Contributor

nicodex commented Sep 5, 2023

No PR (from memory I would expect changes to the Ghidra m68k config files), but if you are looking for the OS structures, a more or less complete 3.1 NDK data type archive can be found here: https://ghidra.nicode.net/Ambermoon/
(the clib function prototypes are not really helpful without much more effort, I'm working on it, but my spare time is very limited)

@mheyer32
Copy link
Author

I think a potential fix is in the Bartman fork:
https://github.com/BartmanAbyss/ghidra-amiga/blob/master/3rdparty/NDK_3.9/include_h/pack.h

They make sure to include pack.h first and then let ghidra parse all NDK headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants