From 8149bd0dd06740208f1c266d8411b9693c54beae Mon Sep 17 00:00:00 2001 From: Leonard Hecker Date: Fri, 2 Aug 2024 21:43:41 +0200 Subject: [PATCH] wint_t is not wchar_t (#17653) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `towupper` return `wint_t` which is `int`. 🤦 ## Validation Steps Performed Open the settings menu. 🤦✅ --- src/cascadia/TerminalSettingsEditor/Utils.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cascadia/TerminalSettingsEditor/Utils.cpp b/src/cascadia/TerminalSettingsEditor/Utils.cpp index afb048b62f5..5fc2fea9995 100644 --- a/src/cascadia/TerminalSettingsEditor/Utils.cpp +++ b/src/cascadia/TerminalSettingsEditor/Utils.cpp @@ -28,7 +28,7 @@ namespace winrt::Microsoft::Terminal::Settings hstring LocalizedNameForEnumName(const std::wstring_view sectionAndEnumType, const std::wstring_view enumValue, const std::wstring_view propertyType) { // Uppercase the first letter to conform to our current Resource keys - auto fmtKey = fmt::format(FMT_COMPILE(L"{}{}{}/{}"), sectionAndEnumType, std::towupper(enumValue[0]), enumValue.substr(1), propertyType); + auto fmtKey = fmt::format(FMT_COMPILE(L"{}{}{}/{}"), sectionAndEnumType, static_cast(std::towupper(enumValue[0])), enumValue.substr(1), propertyType); return GetLibraryResourceString(fmtKey); } }