Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oracle Database core dialect. #777

Open
igalklebanov opened this issue Nov 24, 2023 · 4 comments
Open

Add Oracle Database core dialect. #777

igalklebanov opened this issue Nov 24, 2023 · 4 comments
Labels
built-in dialect Related to a built-in dialect enhancement New feature or request oracle Related to Oracle

Comments

@igalklebanov
Copy link
Member

igalklebanov commented Nov 24, 2023

Hey 👋

Knex supports OracleDB with a core dialect. As part of becoming THE "drop-in" replacement for Knex, we should look for the easy wins in getting as close as reasonable to feature parity. This seems like one.

oracledb (or node-oracledb) has roughly 200k downloads per week, and there's an increase over time:
image
https://npmtrends.com/oracledb

If you want to use Kysely with Oracle DB, please drop a comment OR reaction to this issue. Help us understand the demand in the typescript community for this.

@igalklebanov igalklebanov added enhancement New feature or request built-in dialect Related to a built-in dialect oracle Related to Oracle labels Nov 24, 2023
@igalklebanov igalklebanov changed the title Oracle Database core dialect. Add Oracle Database core dialect. Nov 24, 2023
@igalklebanov igalklebanov pinned this issue Dec 20, 2023
@hinogi
Copy link

hinogi commented Feb 10, 2024

Oracle also offers docker container for easy testing and with node-oracle 6 also easier setup since you don't need a fat client also but can use a nodejs only implementation as well.

@ikdi
Copy link

ikdi commented Mar 21, 2024

It would be great to have Oracle DB support

@igalklebanov
Copy link
Member Author

More numbers for prioritization.

image

Just a hint at oracledb usage with Typescript.

@bslinkrga
Copy link

As unfortunate as it is, some of us are having to work with Oracle whether we'd like to or not, until we can migrate off of it fully I'd like to have our integration be the "least crappy" possible, I love Kysley on some of my other projects and it'd be pretty awesome to have that type safety and beautiful DevX even when being stuck with the legacy db systems. For now I guess we'll have to use knex and do a lot of type casting haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
built-in dialect Related to a built-in dialect enhancement New feature or request oracle Related to Oracle
Projects
None yet
Development

No branches or pull requests

4 participants