Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace gateway should harmonize span errors recorded by Envoy #1462

Open
a-thaler opened this issue Sep 18, 2024 · 1 comment
Open

Trace gateway should harmonize span errors recorded by Envoy #1462

a-thaler opened this issue Sep 18, 2024 · 1 comment
Labels
area/traces TracePipeline kind/feature Categorizes issue or PR as related to a new feature.

Comments

@a-thaler
Copy link
Collaborator

Description
The envoy proxy used by Istio is not following the semantic conventions of OTel properly. Especially one convention is ignored with an overall effect of the usability of the span data, which is about setting the error status in the spans status attribute in case of an error. Instead of setting the error status properly as outlined in https://opentelemetry.io/docs/concepts/signals/traces/#span-status, it introduces a custom boolean attribute "error" as outlined also in https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/observability/tracing#what-data-each-trace-contains.

Instead of introducing custom transformation support and asking every user to add a transformation as workaround, these should happen by default as part of the gateway features.

Goal: Add a transformation for spans which are instrumented by Envoy (as a first clazz citizen of Kyma) which sets the span status to error in case of envoys custom attribute is present.

Criterias:

  • spans emitted by envoy (check instrumentation scope for example) are getting enriched the status "error" in case Envoy custom attribute "error=true" is present on the span
  • if any status is set already, the feature will have no effect
  • E2E tests are assuring the compatibility
  • documentation is added

Reasons

Attachments

Release Notes


@a-thaler a-thaler added area/traces TracePipeline kind/feature Categorizes issue or PR as related to a new feature. labels Sep 18, 2024
Copy link

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 18, 2024
@a-thaler a-thaler removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/traces TracePipeline kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant