Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPIC: Support Git Functions in buildless-variant of function operator. #1315

Open
1 of 8 tasks
kwiatekus opened this issue Dec 12, 2024 · 0 comments
Open
1 of 8 tasks
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@kwiatekus
Copy link
Contributor

kwiatekus commented Dec 12, 2024

Description

Allow functions to be sourced from git repository.
Implement the new logic for git-fetching function sources with the following in mind:

  • libgit2 is dead - find alternative -> GO-GIT
  • allowing users to subscribe to github webhooks would improve devexp when comparing to the process of polling git repo for changes.
  • We should not expect users to create git secrets in our own secret format (see our tutorial). Secrets of related k8s types (ssh key or basic auth) should be supported in serverless.
  • see if we could improve performance and resource consumption for the git fetching itself - it comes into play when a function source is a small part of big monorepo and it would be a big improvement if serverless would not need to download the whole thing.

Reasons

Buildless variant of serverless should also allow for operating functions sourced from git repository.

Acceptance Criteria

  • serveless, when installed in buildless-variant, can operate git functions
  • libgit2 is not used in the implementation
  • user can provide git credentials using secrets that follow k8s secret types for basic auth and ssh key
  • users can optionally define endpoints for github webhooks (as an alternative to polling the repo)

Execution

Testing Strategy (DoD)

Existing integration tests (incl. git-auth integration tests) should prove that git-functions work and contract of Function CRD (v1aloha2) is not broken

Attachments

Related Issues
Based on foundations developed by #1211

@kwiatekus kwiatekus added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 12, 2024
@kwiatekus kwiatekus changed the title Support Git Functions in buildless-variant of function operator. EPIC: Support Git Functions in buildless-variant of function operator. Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant