feat: Add metadata and status helpers to Kyma type #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
7 tasks
c-pius
force-pushed
the
feat/add-kyma-helpers
branch
2 times, most recently
from
3f06f47 to
49690d4
Compare
c-pius
force-pushed
the
feat/add-kyma-helpers
branch
2 times, most recently
from
c6d35b6 to
c440351
Compare
c-pius
force-pushed
the
feat/add-kyma-helpers
branch
from
c440351 to
67e281c
Compare
lindnerby
reviewed
Jan 17, 2025
| @@ -0,0 +1,208 @@ | |||
| package v1beta2_test | |||
There was a problem hiding this comment.
Can we add this pkg to the coverage file?
There was a problem hiding this comment.
I am afraid this can't be done easily. The api module is not included in our unittests make target as we only list the package from lifecycle-manager. If you don't mind, I would propose to tackle this in a follow-up as we will require some chnages to support that I think.
.PHONY: unittest
unittest: ## Run the unit test suite.
go test `go list ./... | grep -v /tests/` -coverprofile cover.out -coverpkg=./...
lindnerby
reviewed
Jan 17, 2025
| @@ -8,6 +8,8 @@ require ( | |||
| sigs.k8s.io/controller-runtime v0.19.4 | |||
| ) | |||
|
|
|||
| require github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect | |||
There was a problem hiding this comment.
Any idea were these indirect dep changes are coming from?
There was a problem hiding this comment.
From adding testify/assert.
lindnerby
reviewed
Jan 17, 2025
api/go.mod
Outdated
| @@ -31,6 +33,7 @@ require ( | |||
| github.com/modern-go/reflect2 v1.0.2 // indirect | |||
| github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect | |||
| github.com/pkg/errors v0.9.1 // indirect | |||
| github.com/stretchr/testify v1.10.0 | |||
There was a problem hiding this comment.
Why is testify in the block of indirect dependencies?
There was a problem hiding this comment.
Good catch, fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
-adds helper functions to the Kyma type
Related issue(s)