Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix is-pr-approved job #426

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Fix is-pr-approved job #426

merged 2 commits into from
Jan 19, 2024

Conversation

mfaizanse
Copy link
Member

@mfaizanse mfaizanse commented Jan 19, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fix is-pr-approved job.

Related issue(s)

@mfaizanse mfaizanse added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2024
@mfaizanse mfaizanse requested review from the1bit and a team as code owners January 19, 2024 09:18
@mfaizanse mfaizanse requested a review from grischperl January 19, 2024 09:18
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 19, 2024
grischperl
grischperl previously approved these changes Jan 19, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 19, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 19, 2024
@mfaizanse mfaizanse changed the title Test PR for backend switch github action Fix is-pr-approved job Jan 19, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 19, 2024
@k15r k15r merged commit 4fe2aa1 into kyma-project:main Jan 19, 2024
11 of 13 checks passed
@mfaizanse mfaizanse deleted the issue345_7 branch January 19, 2024 09:41
@grischperl grischperl modified the milestone: 1.2.0 Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedrichwilken friedrichwilken friedrichwilken approved these changes

@grischperl grischperl grischperl left review comments

@the1bit the1bit Awaiting requested review from the1bit

Assignees

@friedrichwilken friedrichwilken

@grischperl grischperl

Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mfaizanse @friedrichwilken @grischperl @k15r @kyma-bot