Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create release also bumps the rc-tag in the sec-scanners-config on main #489

Closed
2 tasks done
friedrichwilken opened this issue Feb 15, 2024 · 0 comments · Fixed by #543
Closed
2 tasks done

Create release also bumps the rc-tag in the sec-scanners-config on main #489

friedrichwilken opened this issue Feb 15, 2024 · 0 comments · Fixed by #543
Assignees
Labels
area/eventing Issues or PRs related to eventing

Comments

@friedrichwilken
Copy link
Contributor

friedrichwilken commented Feb 15, 2024

Description

In the GitHub Action workflow Create release we now have a job to bump the sec-scanners-config.yaml and the kustomize file. This only happens on release-branches (e.g. release-1.2), but we now also need the sec-scanners-config.yaml on main to be bumped: the rc-tag needs to be bumped to the release version, when releasing.

Hint: You can reuse most of the logic we already use to bump files on the release branch here:

bump-sec-scanners-config:

Reasons

When promoting module releases, some validations need the rc-tag to reflect the version that is about to be release.

AC

  • Create release creates a PR to bump the rc-tag on main
  • Create release waits for PR to be merged

Attachments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing
Projects
None yet
3 participants