Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipment.ServerErrors are not used for FedExProvider #25

Open
MalyutinS opened this issue Jun 24, 2014 · 0 comments
Open

Shipment.ServerErrors are not used for FedExProvider #25

MalyutinS opened this issue Jun 24, 2014 · 0 comments

Comments

@MalyutinS
Copy link

I see that inside FedExProvider you are using ShowNotifications to output errors/notifications. However you are using Debug.WriteLine which is not always good. I also see that there is a Shipment.ServerErrors inside AbstractShippingProvider class, which is already used to store errors from USPS (there is a method protected void AddError(USPSError error)). So I can suggest to use similar logic for all providers and populate Shipment.ServerErrors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants