From 6567519e919cb3c3ac392bd0b57d99d5948eb0cf Mon Sep 17 00:00:00 2001
From: "A.J. Stein" <alexander.stein@gsa.gov>
Date: Mon, 18 Nov 2024 15:31:13 -0500
Subject: [PATCH] Correct typos and URLs for #833 constraint re @Gabeblis
 feedback

Co-authored-by: Gabeblis <gabriel.rodriguez@gsa.gov>
---
 .../constraints/fedramp-external-constraints.xml           | 7 +++----
 .../oscal-version-matches-fedramp-version-FAIL.yaml        | 4 ++--
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/validations/constraints/fedramp-external-constraints.xml b/src/validations/constraints/fedramp-external-constraints.xml
index 5c1d06793..151ab239d 100644
--- a/src/validations/constraints/fedramp-external-constraints.xml
+++ b/src/validations/constraints/fedramp-external-constraints.xml
@@ -37,11 +37,10 @@
                 <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/general-concepts/4-expressing-common-fedramp-template-elements-in-oscal/"/>
             	<message>A FedRAMP document MUST have a marking that defines its data classification.</message>
             </expect>
-            <expect id="oscal-version-matches-fedramp-version" target="oscal-version" level="ERROR"
-                test="$major-version-valid and $minor-version-valid and $patch-version-valid">
-                <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://docs.oasis-open.org/sarif/sarif/v2.1.0"/>                
+            <expect id="oscal-version-matches-fedramp-version" target="oscal-version" test="$major-version-valid and $minor-version-valid and $patch-version-valid" level="ERROR">
+                <prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/general-concepts/oscal-file-concepts/#oscal-syntax-version"/>                
                 <message>A FedRAMP document SHOULD have an OSCAL version that matches the minimally required version for FedRAMP packages ({$fedramp-required-minimum-version} not {.}).</message>
-            </expect>        
+            </expect>          
         </constraints>
     </context>
     <context>
diff --git a/src/validations/constraints/unit-tests/oscal-version-matches-fedramp-version-FAIL.yaml b/src/validations/constraints/unit-tests/oscal-version-matches-fedramp-version-FAIL.yaml
index f9037ac2a..22685b45e 100644
--- a/src/validations/constraints/unit-tests/oscal-version-matches-fedramp-version-FAIL.yaml
+++ b/src/validations/constraints/unit-tests/oscal-version-matches-fedramp-version-FAIL.yaml
@@ -1,7 +1,7 @@
 test-case:
-  name: Positive Test for import-profile-has-available-document
+  name: Positive Test for oscal-version-matches-fedramp-version
   description: >-
-    This test case validates the behavior of constraint import-profile-has-available-document.
+    This test case validates the behavior of constraint oscal-version-matches-fedramp-version.
     Scenario 1 tests: an invalid match below the minimum required version threshold.
     Scenario 2 tests: an invalid match above the implied maximum required version threshold, a major version greater than required.
     Scenario 3 tests: an invalid match because the fedramp-version prop is missing, so a fallthrough default is required.