Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] #84

Closed
evelynmitchell opened this issue Jan 1, 2024 · 1 comment
Closed

[TEST] #84

evelynmitchell opened this issue Jan 1, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@evelynmitchell
Copy link
Contributor

evelynmitchell commented Jan 1, 2024

This, I believe, is naming mismatch.
simple_vision_encoder has VisionEncoder, not SimpleVisionEncoder.
init.py has VisionEncoder
test_simple_vision_encoder has SimpleVisionEncoder.

My suggested fix is to change simple_vision_encoder and init.py to be SimpleVisionEncoder.

_________ ERROR collecting tests/structs/test_simple_vision_encoder.py _________
ImportError while importing test module '/usr/src/zeta/tests/structs/test_simple_vision_encoder.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/structs/test_simple_vision_encoder.py:2: in <module>
    from zeta.structs.simple_vision_encoder import SimpleVisionEncoder
E   ModuleNotFoundError: No module named 'zeta.structs.simple_vision_encoder'```

<!-- POLAR PLEDGE BADGE START -->
## Upvote & Fund

- We're using [Polar.sh](https://polar.sh/kyegomez) so you can upvote and help fund this issue.
- We receive the funding once the issue is completed & confirmed by you.
- Thank you in advance for helping prioritize & fund our backlog.

<a href="https://polar.sh/kyegomez/zeta/issues/84">
<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://polar.sh/api/github/kyegomez/zeta/issues/84/pledge.svg?darkmode=1">
  <img alt="Fund with Polar" src="https://polar.sh/api/github/kyegomez/zeta/issues/84/pledge.svg">
</picture>
</a>
<!-- POLAR PLEDGE BADGE END -->
@evelynmitchell evelynmitchell added the bug Something isn't working label Jan 1, 2024
@vyomakesh09
Copy link
Contributor

I presume I fixed it, just submitted a pr

@kyegomez kyegomez closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants