Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gemini to models init.py #525

Closed
wants to merge 2 commits into from
Closed

Conversation

everettVT
Copy link

@everettVT everettVT commented Jul 5, 2024

Thank you for contributing to Swarms!

Replace this comment with:

  • Description: Added "Gemini" to swarms.models init.py,
  • Issue: None,
  • Dependencies: None,
  • Tag maintainer: @evelynmitchell

📚 Documentation preview 📚: https://swarms--525.org.readthedocs.build/en/525/

@github-actions github-actions bot added the models label Jul 5, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there, thank you for opening an PR ! 🙏🏻 The team was notified and they will get back to you asap.

@evelynmitchell
Copy link
Contributor

Hi everettVT!

Thanks for the PR.

Gemini integration was stalled because the Google Development keys, which are required to test this, were not available outside of the US.

When we add Gemini, we'll do it distinctly, with the test for the presence of the keys before enabling the import in pyproject.toml, and the module in swarms/models

This is something you couldn't have known, and thank you so much for your time, but I cannot approve this PR.

@everettVT
Copy link
Author

Awesome! Thanks! I'll try to find another long hanging fruit to get into the contribution flow. I'll take a look at the issues

@kyegomez
Copy link
Owner

kyegomez commented Jul 6, 2024

@everettVT @evelynmitchell no, it wasn't stalled because of this. It was already here. But It was removed because the package was tooo build and we wanted to simplify build time. If you could implement this with just the requests library I will accept.

@everettVT
Copy link
Author

Makes sense. This will give me practice for vertex AI models afterward.

@kyegomez kyegomez closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants