Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 1.19.3 #128

Closed
mrjasonn opened this issue Jan 26, 2023 · 8 comments
Closed

Add support for 1.19.3 #128

mrjasonn opened this issue Jan 26, 2023 · 8 comments
Labels
duplicate This issue or pull request already exists

Comments

@mrjasonn
Copy link

mrjasonn commented Jan 26, 2023

It's crashing on 1.19.3 so need to update it to be compatible + realms now use 1.19.3 so need to update this mod.
@kvverti
#126 They made a usable version for 1.19.3 so can just merge pull request with (possibly) few changes.

@TechPro424
Copy link

Yes please update

@velnias75
Copy link

Made it at least compiling on 1.19.3, but currently the mixins are not ported.
So it is not really tested yet, but with all - not yet working mixins - excluded the result looked already good.

@kvverti: You may use this as starting point? It already includes my path for #6
Here is my tag: https://github.com/velnias75/colormatic/tree/JustCompileOn-1.19.3 (on branch 1.19.3)

@velnias75
Copy link

velnias75 commented Feb 10, 2023

I got it to work so far, that at least Minecraft is playable in 1.19.3
Either @kvverti will fix the rest, or somebody will help me or take over my branch.

Current sources can be found here: https://github.com/velnias75/colormatic/tree/1.19.3

@mstreurman
Copy link

crash-2023-02-13_01.44.07-client.txt

Minecraft doesn't start with this new version of colormatic. Attached the crashlog

@velnias75
Copy link

As I told, I need either help, ot @kvverti will may use it as starting point.
I just tried to get it at least running on my PC.

@mstreurman
Copy link

As I told, I need either help, ot @kvverti will may use it as starting point. I just tried to get it at least running on my PC.

This was in no way an attack on you or saying you need to fix it, I just wanted to give feedback and a crashlog so there is more information available to work with.

@RU-B0
Copy link

RU-B0 commented Apr 10, 2023

Just wanted to help out:
2 crashes, quilt (probs ignore) and fabric. They have the same error, compiled on my pc, here u go. No idea if this is useful but yk.
FABRIC.txt
QUILT.txt
I got a window on each, white screen, then it instantly crashed with "The game crashed whilst initializing game
Error: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_1092 failed"
I wish this mod was simpler so that it was easy to update...but i like the features...
have a good day!

@kvverti kvverti added the duplicate This issue or pull request already exists label Aug 6, 2023
@kvverti
Copy link
Owner

kvverti commented Aug 6, 2023

Consolidating 1.20 update in #136

@kvverti kvverti closed this as completed Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

6 participants