-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zed GLES backend panic: create_platform_window_surface during resize #133
Comments
Zed works fine when disabling transparency: |
Interesting, so these attributes are incorrect
|
Just tried building Zed with the changes in #145 and it still crashes with the same error. Can this be reopened?
|
If you can build, it would help if you could narrow it down a bit by playing with this section let mut attributes = vec![
egl::RENDER_BUFFER,
// We don't want any of the buffering done by the driver, because we
// manage a swapchain on our side.
// Some drivers just fail on surface creation seeing `EGL_SINGLE_BUFFER`.
if cfg!(any(target_os = "android", target_os = "macos", windows)) {
egl::BACK_BUFFER
} else {
egl::SINGLE_BUFFER
},
];
//TODO: detect if linear color space is supported
match inner.egl.srgb_kind {
SrgbFrameBufferKind::None => {}
SrgbFrameBufferKind::Core | SrgbFrameBufferKind::Khr => {
attributes.push(egl::GL_COLORSPACE);
attributes.push(egl::GL_COLORSPACE_SRGB);
}
} |
Found this note in the documentation:
So I tried to add this hotfix: if let Some(s) = inner.swapchain.take() {
inner.egl.instance.destroy_surface(inner.egl.display, s.surface).unwrap();
} This helped on my PC, Zed no longer crashes. So I guess the proper fix of this issue is implementing (however, Zed uses (there is another crash |
Awesome, do you want to submit a PR for this, @andreymal ? |
No, I actually don't know any GL |
The GLES backend for Zed is crashing for me under both X11 and Wayland. This has been occuring since at least zed-industries/zed#13114 but has probably been present for much longer. This occurs whenever you resize the window (if doing the hello_world example, which has been there the whole time) or at startup if running Zed (though I don't think this has always been the case).
This is what gets printed out:
And on wayland I get this:
My DE is gnome.
The text was updated successfully, but these errors were encountered: