Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for ManyToOneConnectTrans doesn't perform any checks #24

Open
tilk opened this issue Dec 5, 2024 · 0 comments
Open

Test for ManyToOneConnectTrans doesn't perform any checks #24

tilk opened this issue Dec 5, 2024 · 0 comments
Labels
bug Something isn't working tests Tests and testbenches

Comments

@tilk
Copy link
Member

tilk commented Dec 5, 2024

I believe that the test for ManyToOneConnectTrans, I think from @lekcyjna123, don't test anything. It has a consumer process which consists of a while loop with condition which is false on the start, so the loop body (which contains all the assertions) doesn't execute at all.

This issue was split from kuznia-rdzeni/coreblocks#752.
@tilk tilk added bug Something isn't working tests Tests and testbenches labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working tests Tests and testbenches
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tilk