Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding support for visualization type and subtype #11

Open
ghost opened this issue Apr 12, 2021 · 1 comment
Open

Consider adding support for visualization type and subtype #11

ghost opened this issue Apr 12, 2021 · 1 comment

Comments

@ghost
Copy link

ghost commented Apr 12, 2021

Consider adding support for subtypes in supported visualizations.

Chart is very vague. What was #7 ended up being "Death Count per Personality Type" chart. While we could just add it to supported list and render it directly, I think it makes more sense to have something like this in supported visualizations response:

interface SupportedVisualization {
    type: string;
    subtype: string;
    prompt: string;
}

type and subtype would be used to vary between visualizations. Could be chosen with rendered buttons or a dropdown. Would need some UX input to determine.

prompt would be used to display message for user on the button/dropdown as Death Count per Personality Type should not be considered a valid subtype, but it'd be good for UX.

What do you guys think @Lauralicja @czaaru ?

@Lauralicja
Copy link

Type: what do we want to see, Death/Money...
Subtype: how do we want to see, Chart/Boxplot/Map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant