Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Starting validation" StarlarkRunProgress message has incorrect TotalSteps field #2595

Open
MegaRedHand opened this issue Nov 8, 2024 · 2 comments
Labels
bug Something isn't working papercut sdk for bugs/FRs relating to our SDK

Comments

@MegaRedHand
Copy link

MegaRedHand commented Nov 8, 2024

What's your CLI version?

1.4.1

Description & steps to reproduce

When running a Starlark package via the SDK's RunStarlarkPackage (or its remote counterpart), I'm fetching the response from the channel and formatting them manually for printing. When reaching the "Starting validation" message we can see the total steps correspond to the execution phase's instead of the validation's.

Note: I'm using the Go SDK, but I suspect this isn't SDK-specific.

Desired behavior

I'd expect the "Starting validation" message to have the total steps of the validation phase instead of the execution phase's.

What is the severity of this bug?

Papercut; this bug is frustrating, but I have a workaround.

What area of the product does this pertain to?

SDK: the Software Development Kit libraries - Typescript, Go, etc.

@MegaRedHand MegaRedHand added the bug Something isn't working label Nov 8, 2024
@github-actions github-actions bot added papercut sdk for bugs/FRs relating to our SDK labels Nov 8, 2024
@tedim52
Copy link
Contributor

tedim52 commented Nov 12, 2024

Hey @MegaRedHand thanks for making the issue! Will take a look to see why this. Also curious, could you elaborate more on how this is causing friction in your workflow? (eg. are you expecting using number steps as a termination condition?)

@MegaRedHand
Copy link
Author

Hey! Thanks for the response! I'm using the engine responses to show the user a progress bar.
Initially, I was using the steps returned in the "Starting validation"/"Starting execution" messages to set the "total steps". Due to this, however, I use the info from the following messages instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working papercut sdk for bugs/FRs relating to our SDK
Projects
None yet
Development

No branches or pull requests

2 participants