Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Replace time.now() with run_sh or run_python #114

Closed
mieubrisse opened this issue Aug 31, 2023 · 1 comment · Fixed by #116
Closed

Replace time.now() with run_sh or run_python #114

mieubrisse opened this issue Aug 31, 2023 · 1 comment · Fixed by #116
Assignees
Labels
help wanted Extra attention is needed

Comments

@mieubrisse
Copy link
Contributor

There is a time.now() call here:

final_genesis_timestamp = (time.now() + CL_GENESIS_DATA_GENERATION_TIME + num_participants*CL_NODE_STARTUP_TIME).unix

This is problematic, because it blocks the entire package from being used with idempotent runs.

What we need to do: replace the in-Starlark time.now() generation (which is an interpretation-time value) with a runtime value by generating the current time via run_sh or run_python. Hopefully, this should be the only change needed.

@leeederek
Copy link
Contributor

+1 lets prioritize this. we have a user who is doing rapid dev loops with eth2-package and the lack of idempotent runs is causing friction.

@leeederek leeederek added the help wanted Extra attention is needed label Sep 3, 2023
@h4ck3rk3y h4ck3rk3y self-assigned this Sep 4, 2023
@h4ck3rk3y h4ck3rk3y linked a pull request Sep 4, 2023 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants