Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React/refactoring chk button base #430

Closed
wants to merge 14 commits into from

Conversation

kobakazu0429
Copy link
Member

@kobakazu0429 kobakazu0429 commented Dec 31, 2019

closed #356

WHY

ちょっくれ未解決問題の一つである ChkButtonBase キモすぎ問題を解決したかった

WHAT

やったこと

  • ChkThemeProvider の導入
    • 色とかフォントの大きさとかを styled-components の中で解決できる
  • MoreButton のみラップした
  • デザインは Storybook を見て欲しい

やってないこと

@netlify
Copy link

netlify bot commented Dec 31, 2019

Deploy preview for cho-kure-web-storybook ready!

Built with commit 1c73b86

https://deploy-preview-430--cho-kure-web-storybook.netlify.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChkButtonBaseをリファクトする
2 participants