Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom heights bring too many isssues #23

Open
ujikol opened this issue Mar 10, 2021 · 5 comments
Open

Custom heights bring too many isssues #23

ujikol opened this issue Mar 10, 2021 · 5 comments

Comments

@ujikol
Copy link

ujikol commented Mar 10, 2021

I like the theme a lot, But the implementation of the different heights brings too many troubles for me:

  1. text-scale-adjust ignores at least all headings
  2. misalignment in agenda caused by tags
  3. other misalignment in column views
  4. ...

Is there a way to just use default behavior for heights?

And then I will also disable variable-pitch to avoid further misalignment. What's the best way to set fixed-pitch for all with Iosevka font?

Thanks

@kunalb
Copy link
Owner

kunalb commented Mar 10, 2021

Disabling variable pitch should make everything fixed-pitch and flat.

For setting heights to be fixed, customizing poet-theme-variable-headers to nil should make everything equally sized/disable the different heights, but I'm not sure if that will make text-scale-adjust behave smoothly.

In the worst case you can directly edit the theme to simply remove all height customization; I'll think about making that an explicit option.

@ujikol ujikol changed the title Custom heights bring to much isssues Custom heights bring too many isssues Apr 30, 2021
@ujikol
Copy link
Author

ujikol commented Apr 30, 2021

(setq poet-theme-variable-headers nil) does not enable the scaling of headings.

I also tried
(custom-theme-set-faces 'poet(org-level-1 ((t (:inherit default :foreground "#e0e0e0" :height 98)))))
(set-face-attribute 'org-level-2 t :height 98)
`
Neither worked.

Other ideas?

@ujikol
Copy link
Author

ujikol commented Apr 30, 2021

The height of the face is changed when i put the set-face-attribute in the text-mode-hook.

But again there is no scaling of the headings.

@tangxinfa
Copy link

tangxinfa commented Sep 3, 2021

Disable custom heights:

(advice-add 'poet-theme--height :around (lambda (orig-fun multiplier)
    (face-attribute 'default :height)))

@kmgolden
Copy link

@tangxinfa this worked for me. Thank you! @kunalb maybe add this to the Readme for resolution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants