Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): remove ENABLE_E2E_DEBUG_GLOBALLY env and rely on github #12257

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Dec 12, 2024

Motivation

GitHub Actions provides the ACTIONS_RUNNER_DEBUG environment variable to enable debugging. We should leverage it.

Implementation information

Instead of using ENABLE_E2E_DEBUG_GLOBALLY we can rely on ACTIONS_RUNNER_DEBUG env.

Supporting documentation

https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/troubleshooting-workflows/enabling-debug-logging

@lukidzi lukidzi requested a review from a team as a code owner December 12, 2024 12:42
@lukidzi lukidzi requested review from michaelbeaumont and Icarus9913 and removed request for a team December 12, 2024 12:42
@lukidzi lukidzi changed the title chore(e2e): remove ENABLE_E2E_DEBUG_GLOBALLY env and relay on github chore(e2e): remove ENABLE_E2E_DEBUG_GLOBALLY env and rely on github Dec 12, 2024
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@lukidzi lukidzi merged commit 68e11f2 into kumahq:master Dec 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants