-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(github): sanitize title input in pr-check action #12252
Merged
bartsmykla
merged 5 commits into
master
from
ci/fix-pr-check-gh-action-to-sanitize-title-input
Dec 12, 2024
Merged
ci(github): sanitize title input in pr-check action #12252
bartsmykla
merged 5 commits into
master
from
ci/fix-pr-check-gh-action-to-sanitize-title-input
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent shell script injection via PR titles, which could allow running malicious shell code in actions. This made it easy to leak secrets and posed a broader security risk. Signed-off-by: Bart Smykla <[email protected]>
bartsmykla
added
the
ci/skip-test
PR: Don't run unit and e2e tests (maybe this is just a doc change)
label
Dec 12, 2024
bartsmykla
changed the title
ci(gh): sanitize title input in pr-check GitHub action
ci(gh): sanitize title input in pr-check GitHub action (test: "; echo hello; echo ")
Dec 12, 2024
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
slonka
approved these changes
Dec 12, 2024
bartsmykla
changed the title
ci(gh): sanitize title input in pr-check GitHub action (test: "; echo hello; echo ")
ci(gh): sanitize title input in pr-check GitHub action (test: "; env; echo ")
Dec 12, 2024
bartsmykla
changed the title
ci(gh): sanitize title input in pr-check GitHub action (test: "; env; echo ")
ci(gh): sanitize title input in pr-check GitHub action (test: "; echo "hello"; echo ")
Dec 12, 2024
Signed-off-by: Bart Smykla <[email protected]>
bartsmykla
changed the title
ci(gh): sanitize title input in pr-check GitHub action (test: "; echo "hello"; echo ")
ci(gh): sanitize title input in pr-check GitHub action (test: "; echo hello; echo ")
Dec 12, 2024
Signed-off-by: Bart Smykla <[email protected]>
bartsmykla
changed the title
ci(gh): sanitize title input in pr-check GitHub action (test: "; echo hello; echo ")
ci(gh): sanitize title input in pr-check GitHub action (test: '; echo "hello"; echo ')
Dec 12, 2024
bartsmykla
changed the title
ci(gh): sanitize title input in pr-check GitHub action (test: '; echo "hello"; echo ')
ci(gh): sanitize title input in pr-check GitHub action
Dec 12, 2024
Signed-off-by: Bart Smykla <[email protected]>
lahabana
approved these changes
Dec 12, 2024
lahabana
changed the title
ci(gh): sanitize title input in pr-check GitHub action
ci(github): sanitize title input in pr-check GitHub action
Dec 12, 2024
lahabana
changed the title
ci(github): sanitize title input in pr-check GitHub action
ci(github): sanitize title input in pr-check action
Dec 12, 2024
Signed-off-by: Bart Smykla <[email protected]>
bartsmykla
deleted the
ci/fix-pr-check-gh-action-to-sanitize-title-input
branch
December 12, 2024 09:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Prevent shell script injection via PR titles, which could allow running malicious shell code in actions. This made it easy to leak secrets and posed a broader security risk.