Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(app): add common logging of version, config on startup #12245

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Dec 12, 2024

Motivation

In a customer investigation it took a while to figure what the version of the dp was.
Also the logs between the CP and DP were quite different.

Implementation

  • Log version and config as early as possible on startup of cp and dp
  • Use similar log messages for cp and dp to develop muscle memory
  • Simplify api to get json safe to print

In a customer investigation it took a while to figure what the version
of the dp is.
Also the logs between the CP and DP were quite different.
Made this similar and log the version and the config in the same line
for quicker troubleshooting.

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana requested a review from a team as a code owner December 12, 2024 00:57
@lahabana lahabana requested review from michaelbeaumont and bartsmykla and removed request for a team December 12, 2024 00:57
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should we backport it maybe?

@lahabana
Copy link
Contributor Author

I don't think it fits our backporting rules

@lahabana lahabana merged commit c26b168 into kumahq:master Dec 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants