fix(helm): add back KUMA_DATAPLANE_NAME to egress/ingress deployment
#12244
+26
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2.5.x we introduced a change to not rely on composed env var. However, sometimes folks update helm before their binaries. Therefore we introduce the removed env var to be able to run 2.4 proxies with helm charts for version 2.6 and 2.7 fix kumahq#12241 Signed-off-by: Charly Molter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2.5.x we introduced a change to not rely on composed env var.
However, sometimes folks update helm before their binaries. Therefore we introduce the removed env var to be able to run 2.4 proxies with helm charts for version 2.6 and 2.7
fix #12241
Motivation
Implementation information
Supporting documentation
Fix #XX