Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kds): remove context from map on stream close #12243

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Dec 11, 2024

Motivation

The application's memory usage was slowly increasing but did not correlate with the number of active connections. I decided to investigate the memory usage and noticed some context entries. While reviewing the code, I discovered that we are not cleaning up the map of streams and contexts. I'm not certain if this is the primary issue, but it could be a contributing factor.

Implementation information

Implemented the OnDeltaStreamClosed method to remove entries from the map when a stream is closed.

Supporting documentation

xref: https://github.com/Kong/kong-mesh/issues/6616

@lukidzi lukidzi requested a review from a team as a code owner December 11, 2024 16:38
@lukidzi lukidzi requested review from bartsmykla and Icarus9913 and removed request for a team December 11, 2024 16:38
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@lukidzi lukidzi enabled auto-merge December 11, 2024 17:01
@lukidzi lukidzi merged commit f1fa968 into kumahq:master Dec 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants