fix(kds): remove context from map on stream close #12243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The application's memory usage was slowly increasing but did not correlate with the number of active connections. I decided to investigate the memory usage and noticed some context entries. While reviewing the code, I discovered that we are not cleaning up the map of streams and contexts. I'm not certain if this is the primary issue, but it could be a contributing factor.
Implementation information
Implemented the
OnDeltaStreamClosed
method to remove entries from the map when a stream is closed.Supporting documentation
xref: https://github.com/Kong/kong-mesh/issues/6616