Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(CHANGELOG.md): updating changelog and version files #12210

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

kumahq[bot]
Copy link
Contributor

@kumahq kumahq bot commented Dec 10, 2024

Automated changes by create-pull-request GitHub action

@kumahq kumahq bot added the ci/auto-merge PR: Approve and Merge PRs automatically label Dec 10, 2024
@kumahq kumahq bot requested a review from a team as a code owner December 10, 2024 07:22
@kumahq kumahq bot added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Dec 10, 2024
@kumahq kumahq bot requested review from michaelbeaumont and slonka and removed request for a team December 10, 2024 07:22
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@kumahq kumahq bot enabled auto-merge (squash) December 10, 2024 07:22
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we removing these versions

@kumahq kumahq bot force-pushed the chore/update-changelog branch from d1a2732 to 994e376 Compare December 10, 2024 10:05
@kumahq kumahq bot force-pushed the chore/update-changelog branch from 994e376 to 54fe615 Compare December 11, 2024 02:21
@jijiechen
Copy link
Member

@bartsmykla I'll have a look at the workflow
We had exiting and merged PR did the same operation: https://github.com/kumahq/kuma/pull/12133/files

Signed-off-by: kumahq[bot] <110050114+kumahq[bot]@users.noreply.github.com>
@kumahq kumahq bot force-pushed the chore/update-changelog branch from 54fe615 to a2ff703 Compare December 11, 2024 07:38
@jijiechen
Copy link
Member

It an intentional change done recently, we don't show change logs for versions older than 2.2.0
#12132

@jijiechen jijiechen dismissed bartsmykla’s stale review December 11, 2024 08:20

The changes match our expectation.

@kumahq kumahq bot merged commit 8baca09 into master Dec 11, 2024
11 checks passed
@kumahq kumahq bot deleted the chore/update-changelog branch December 11, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/auto-merge PR: Approve and Merge PRs automatically ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants