refactor(*): replace experimental maps and slices with stdlib
#12141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juneezee
requested review from
jijiechen and
slonka
and removed request for
a team
Juneezee
changed the title
maps and slices with stdlibmaps and slices with stdlib
The experimental functions are now available in the standard library in Go 1.21 [1] and Go 1.23 [2]. [1]: https://go.dev/doc/go1.21#slices [2]: https://go.dev/doc/go1.23#iterators Signed-off-by: Eng Zer Jun <[email protected]>
Juneezee
force-pushed
the
refactor/experimental-maps-slices
branch
from
26b571b to
5b9ae8f
Compare
jijiechen
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We upgraded to Go 1.23 in #11363. The experimental functions are now part of the standard library as of Go 1.21 and Go 1.23.
Reference: https://go.dev/doc/go1.21#slices
Reference: https://go.dev/doc/go1.23#iterators
Implementation information
The key difference is that
maps.Keysandmaps.Valuesin thegolang.org/x/exppackage return a slice, whereasmaps.Keysandmaps.Valuesin the standard library return an iterator. To work with slices, we need to useslices.Collectto convert the iterator into a slice.Supporting documentation