Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): disable meshmtls test with delegated gateway (backport of #12108) #12119

Closed
wants to merge 1 commit into from
Closed

test(e2e): disable meshmtls test with delegated gateway (backport of #12108) #12119

wants to merge 1 commit into from

Conversation

kumahq[bot]
Copy link
Contributor

@kumahq kumahq bot commented Nov 27, 2024

Automatic cherry-pick of #12108 for branch release-2.7

Generated by action

cherry-picked commit c542d02
⚠️ ⚠️ ⚠️ Conflicts happened when cherry-picking! ⚠️ ⚠️ ⚠️

On branch release-2.7
Your branch is up to date with 'origin/release-2.7'.

You are currently cherry-picking commit c542d022d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   test/e2e_env/kubernetes/gateway/delegated.go
	deleted by us:   test/e2e_env/kubernetes/gateway/delegated/meshtls.go

no changes added to commit (use "git add" and/or "git commit -a")

@lukidzi @kumahq
test(e2e): disable meshmtls test with delegated gateway (#12108)
18c9414 
I noticed a flake and began investigating. I discovered the TLS version
and cipher are not configured for the delegated gateway. Since the
`MeshTLS` policy is a `from` policy and the delegated gateway has no
inbound listener, the policy cannot be matched to any listener. The test
passed because the request was sent before the configuration was fully
delivered.

Excluded the test and added `MustPassRepeatedly(5)` to ensure better
validation once the issue is resolved.

<!-- Is there a MADR? An Issue? A related PR? -->

xref: #12107

<!--
> Changelog: skip
-->
<!--
Uncomment the above section to explicitly set a [`> Changelog:` entry
here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)?
-->

Signed-off-by: Lukasz Dziedziak <[email protected]>
@kumahq kumahq bot requested a review from a team as a code owner November 27, 2024 12:38
@kumahq kumahq bot requested review from jijiechen and slonka and removed request for a team November 27, 2024 12:38
@lukidzi lukidzi closed this Nov 27, 2024
@bartsmykla bartsmykla deleted the chore/backport-release-2.7-12108 branch December 11, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jijiechen jijiechen Awaiting requested review from jijiechen jijiechen is a code owner automatically assigned from kumahq/kuma-maintainers

@slonka slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
conflict release-2.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lukidzi