feat(kuma-dp): disable application probe proxy by default on Universal #12002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jay Chen <[email protected]>
jijiechen
requested review from
bartsmykla and
Icarus9913
and removed request for
a team
lukidzi
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fixes #11854
Implementation information
kuma-dpdecides whether to start the application probe proxy according to port settings onapplicationProbeProxyServer.port, when it's configured to0, the server won't start.It was set to
9001by default. So now change this default value to "not set", which will be actually0.On Kubernetes, we have another injector configuration item which still defaults to
9901, it will eventually be applied to thekuma-dpprocess in the pod. Users can use environment variable and data plane pod annotation to configure this port. So the functionality of the feature is not impacted at all.Supporting documentation
https://kuma.io/docs/2.9.x/policies/service-health-probes/#application-probe-proxy