-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): change go-control-plane version #12000
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukasz Dziedziak <[email protected]>
lukidzi
added
the
ci/run-full-matrix
PR: Runs all possible e2e test combination (expensive use carefully)
label
Nov 8, 2024
lukidzi
requested review from
bartsmykla and
Icarus9913
and removed request for
a team
November 8, 2024 13:09
The goal is to remove v0.13.2 and we are using it in release-2.9, so we need to backport the change |
michaelbeaumont
approved these changes
Nov 12, 2024
backporting to release-2.6 with action |
kumahq bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
We aim to keep our fork of go-control-plane synchronized with the upstream repository. We’ve documented our proposed steps in a [MADR](https://docs.google.com/document/d/1n9hQkTubtODIJl_NThF0uvhcqXJo5OU-lU3X3N81hW4/edit?tab=t.0#heading=h.n6cmlf1eel2z), which outlines the process we plan to follow. I've created a release `v0.13.1-kong-1`, diverging from `v0.13.1`, so we can use a version that includes our custom changes. The goal is to keep our tags distinct from the upstream, so I plan to remove `v0.13.2` from our fork to avoid confusion. https://docs.google.com/document/d/1n9hQkTubtODIJl_NThF0uvhcqXJo5OU-lU3X3N81hW4/edit?tab=t.0#heading=h.n6cmlf1eel2z Fix #XX <!-- > Changelog: skip --> <!-- Uncomment the above section to explicitly set a [`> Changelog:` entry here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)? --> Signed-off-by: Lukasz Dziedziak <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
We aim to keep our fork of go-control-plane synchronized with the upstream repository. We’ve documented our proposed steps in a [MADR](https://docs.google.com/document/d/1n9hQkTubtODIJl_NThF0uvhcqXJo5OU-lU3X3N81hW4/edit?tab=t.0#heading=h.n6cmlf1eel2z), which outlines the process we plan to follow. I've created a release `v0.13.1-kong-1`, diverging from `v0.13.1`, so we can use a version that includes our custom changes. The goal is to keep our tags distinct from the upstream, so I plan to remove `v0.13.2` from our fork to avoid confusion. https://docs.google.com/document/d/1n9hQkTubtODIJl_NThF0uvhcqXJo5OU-lU3X3N81hW4/edit?tab=t.0#heading=h.n6cmlf1eel2z Fix #XX <!-- > Changelog: skip --> <!-- Uncomment the above section to explicitly set a [`> Changelog:` entry here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)? --> Signed-off-by: Lukasz Dziedziak <[email protected]>
This was referenced Nov 12, 2024
kumahq bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
We aim to keep our fork of go-control-plane synchronized with the upstream repository. We’ve documented our proposed steps in a [MADR](https://docs.google.com/document/d/1n9hQkTubtODIJl_NThF0uvhcqXJo5OU-lU3X3N81hW4/edit?tab=t.0#heading=h.n6cmlf1eel2z), which outlines the process we plan to follow. I've created a release `v0.13.1-kong-1`, diverging from `v0.13.1`, so we can use a version that includes our custom changes. The goal is to keep our tags distinct from the upstream, so I plan to remove `v0.13.2` from our fork to avoid confusion. https://docs.google.com/document/d/1n9hQkTubtODIJl_NThF0uvhcqXJo5OU-lU3X3N81hW4/edit?tab=t.0#heading=h.n6cmlf1eel2z Fix #XX <!-- > Changelog: skip --> <!-- Uncomment the above section to explicitly set a [`> Changelog:` entry here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)? --> Signed-off-by: Lukasz Dziedziak <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
## Motivation We aim to keep our fork of go-control-plane synchronized with the upstream repository. We’ve documented our proposed steps in a [MADR](https://docs.google.com/document/d/1n9hQkTubtODIJl_NThF0uvhcqXJo5OU-lU3X3N81hW4/edit?tab=t.0#heading=h.n6cmlf1eel2z), which outlines the process we plan to follow. ## Implementation information I've created a release `v0.13.1-kong-1`, diverging from `v0.13.1`, so we can use a version that includes our custom changes. The goal is to keep our tags distinct from the upstream, so I plan to remove `v0.13.2` from our fork to avoid confusion. ## Supporting documentation https://docs.google.com/document/d/1n9hQkTubtODIJl_NThF0uvhcqXJo5OU-lU3X3N81hW4/edit?tab=t.0#heading=h.n6cmlf1eel2z Fix #XX <!-- > Changelog: skip --> <!-- Uncomment the above section to explicitly set a [`> Changelog:` entry here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)? --> Signed-off-by: Lukasz Dziedziak <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
We aim to keep our fork of go-control-plane synchronized with the upstream repository. We’ve documented our proposed steps in a [MADR](https://docs.google.com/document/d/1n9hQkTubtODIJl_NThF0uvhcqXJo5OU-lU3X3N81hW4/edit?tab=t.0#heading=h.n6cmlf1eel2z), which outlines the process we plan to follow. I've created a release `v0.13.1-kong-1`, diverging from `v0.13.1`, so we can use a version that includes our custom changes. The goal is to keep our tags distinct from the upstream, so I plan to remove `v0.13.2` from our fork to avoid confusion. https://docs.google.com/document/d/1n9hQkTubtODIJl_NThF0uvhcqXJo5OU-lU3X3N81hW4/edit?tab=t.0#heading=h.n6cmlf1eel2z Fix #XX <!-- > Changelog: skip --> <!-- Uncomment the above section to explicitly set a [`> Changelog:` entry here](https://github.com/kumahq/kuma/blob/master/CONTRIBUTING.md#submitting-a-patch)? --> Signed-off-by: Lukasz Dziedziak <[email protected]>
lukidzi
added a commit
that referenced
this pull request
Nov 13, 2024
…2029) Automatic cherry-pick of #12000 for branch release-2.9 Generated by [action](https://github.com/kumahq/kuma/actions/runs/11796557983) cherry-picked commit 9565a54 Signed-off-by: Lukasz Dziedziak <[email protected]> Co-authored-by: Lukasz Dziedziak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We aim to keep our fork of go-control-plane synchronized with the upstream repository. We’ve documented our proposed steps in a MADR, which outlines the process we plan to follow.
Implementation information
I've created a release
v0.13.1-kong-1
, diverging fromv0.13.1
, so we can use a version that includes our custom changes. The goal is to keep our tags distinct from the upstream, so I plan to removev0.13.2
from our fork to avoid confusion.Supporting documentation
https://docs.google.com/document/d/1n9hQkTubtODIJl_NThF0uvhcqXJo5OU-lU3X3N81hW4/edit?tab=t.0#heading=h.n6cmlf1eel2z
Fix #XX