fix(kuma-cp): avoid concurrent access on resource meta #11997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some places where labels on meta weren't not cloned when duplicating the meta. Signed-off-by: Charly Molter <[email protected]>
lahabana
requested review from
bartsmykla and
Icarus9913
and removed request for
a team
Signed-off-by: Mike Beaumont <[email protected]>
|
@lobkovilya maybe also interesting for you |
michaelbeaumont
approved these changes
Nov 12, 2024
|
backporting to release-2.6 with action |
|
backporting to release-2.8 with action |
kumahq bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
There were some places where labels on meta weren't not cloned when duplicating the meta. Walked the code for odd usages of `GetLabels()`. See also #11886 Signed-off-by: Charly Molter <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
There were some places where labels on meta weren't not cloned when duplicating the meta. Walked the code for odd usages of `GetLabels()`. See also #11886 Signed-off-by: Charly Molter <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
There were some places where labels on meta weren't not cloned when duplicating the meta. Walked the code for odd usages of `GetLabels()`. See also #11886 Signed-off-by: Charly Molter <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
There were some places where labels on meta weren't not cloned when duplicating the meta. Walked the code for odd usages of `GetLabels()`. See also #11886 Signed-off-by: Charly Molter <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
kumahq bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
There were some places where labels on meta weren't not cloned when duplicating the meta. Walked the code for odd usages of `GetLabels()`. See also #11886 Signed-off-by: Charly Molter <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
This was referenced Nov 12, 2024
michaelbeaumont
added a commit
that referenced
this pull request
Nov 12, 2024
…11997) (#12024) Automatic cherry-pick of #11997 for branch release-2.9 Generated by [action](https://github.com/kumahq/kuma/actions/runs/11796491720) cherry-picked commit c3d7187 Signed-off-by: Charly Molter <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Charly Molter <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
michaelbeaumont
added a commit
that referenced
this pull request
Nov 12, 2024
…11997) (#12023) Automatic cherry-pick of #11997 for branch release-2.7 Generated by [action](https://github.com/kumahq/kuma/actions/runs/11796491720) cherry-picked commit c3d7187 Signed-off-by: Charly Molter <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Charly Molter <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
michaelbeaumont
added a commit
that referenced
this pull request
Nov 12, 2024
…11997) (#12022) Automatic cherry-pick of #11997 for branch release-2.8 Generated by [action](https://github.com/kumahq/kuma/actions/runs/11796491720) cherry-picked commit c3d7187 Signed-off-by: Charly Molter <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Charly Molter <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
michaelbeaumont
added a commit
that referenced
this pull request
Nov 13, 2024
…11997) (#12021) Automatic cherry-pick of #11997 for branch release-2.6 Generated by [action](https://github.com/kumahq/kuma/actions/runs/11796491720) Signed-off-by: Charly Molter <[email protected]> Signed-off-by: Mike Beaumont <[email protected]> Co-authored-by: Charly Molter <[email protected]> Co-authored-by: Mike Beaumont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There were some places where labels on meta weren't not cloned when duplicating the meta.
Implementation information
Walked the code for odd usages of
GetLabels().Supporting documentation
xref #11886