Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All first column should always have a copy button #3180

Open
lahabana opened this issue Nov 13, 2024 · 2 comments
Open

All first column should always have a copy button #3180

lahabana opened this issue Nov 13, 2024 · 2 comments
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone

Comments

@lahabana
Copy link
Contributor

What happened?

In the Dataplane proxies list for example it's missing.

Let's go over all our lists and make sure we have copy buttons.

@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Nov 13, 2024
@lahabana lahabana added this to the 2.10.x milestone Nov 13, 2024
@johncowen
Copy link
Contributor

Couple things we said if we are ever looking for the reasoning in the future:

  • We should always copy the thing the user can see, so if we see name-of-thing we should copy name-of-thing not name-of-thing.namespace.
  • Because we wrap the "name of the thing" in a link, its slightly more difficult to copy by just selecting and hitting ctrl-c, therefore there is a good reason to use a copy button on these things rather than just assume the user can copy these normally.

@lobkovilya lobkovilya added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

4 participants
@johncowen @lahabana @lobkovilya and others